Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FCT-1311 - reduce icon bundle size 2 #3011

Closed
wants to merge 2 commits into from
Closed

FCT-1311 - reduce icon bundle size 2 #3011

wants to merge 2 commits into from

Conversation

ByronDWall
Copy link
Contributor

This pull request includes a minor update to the CONTRIBUTING.md file. The change updates the instructions for generating React component files from SVG icons, specifying the use of the svgr CLI instead of svgo.

  • CONTRIBUTING.md: Updated the tool used for generating React component files from SVG icons to svgr and changed the template file reference to svgr/config.js.

@ByronDWall
feat(icons): [publish_preview] update icon template with new imports,…
5c444e8 
… remove unnecessary styling boilerplate from icons template
@ByronDWall ByronDWall self-assigned this Dec 10, 2024
@ByronDWall ByronDWall requested a review from a team as a code owner December 10, 2024 18:01
@ByronDWall ByronDWall requested review from stephsprinkle, jaikamat, ddouglasz, tylermorrisford and misama-ct and removed request for a team December 10, 2024 18:01
@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 6:06pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4851395

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

tylermorrisford
tylermorrisford approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@tylermorrisford tylermorrisford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful!

@ByronDWall ByronDWall closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylermorrisford tylermorrisford tylermorrisford approved these changes

@stephsprinkle stephsprinkle Awaiting requested review from stephsprinkle stephsprinkle is a code owner automatically assigned from commercetools/first-contact-team-fe

@jaikamat jaikamat Awaiting requested review from jaikamat jaikamat is a code owner automatically assigned from commercetools/first-contact-team-fe

@ddouglasz ddouglasz Awaiting requested review from ddouglasz ddouglasz is a code owner automatically assigned from commercetools/first-contact-team-fe

@misama-ct misama-ct Awaiting requested review from misama-ct misama-ct is a code owner automatically assigned from commercetools/first-contact-team-fe

Assignees

@ByronDWall ByronDWall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ByronDWall @tylermorrisford